Port StatementRewrite::rewrite_unique_id#1174
Merged
Merged
Conversation
This is mostly a direct port, other than lifting where we get the UniqueId generator up a level so `rewrite_unique_id` can be infallible. (NB: The only reason getting the generator can fail is if the config is invalid. We should be checking that config way earlier, and fetching the generator should be infallible). This marks the final function in `StatementRewrite` that needed to be ported. We can now begin the structural change of removing the old AST from that struct entirely. However, that will be a large enough change on its own to warrant a separate PR, so as of this commit we still do the deparse/reparse/deparse/reparse dance.
levkk
previously approved these changes
Jul 10, 2026
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
meskill
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is mostly a direct port, other than lifting where we get the UniqueId generator up a level so
rewrite_unique_idcan be infallible. (NB: The only reason getting the generator can fail is if the config is invalid. We should be checking that config way earlier, and fetching the generator should be infallible).This marks the final function in
StatementRewritethat needed to be ported. We can now begin the structural change of removing the old AST from that struct entirely. However, that will be a large enough change on its own to warrant a separate PR, so as of this commit we still do the deparse/reparse/deparse/reparse dance.